Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Rename generic bitstream.h to cc_bitstream.h #1436 #1543

Merged
merged 3 commits into from
Jul 5, 2023
Merged

[FIX] Rename generic bitstream.h to cc_bitstream.h #1436 #1543

merged 3 commits into from
Jul 5, 2023

Conversation

prateekmedia
Copy link
Member

@prateekmedia prateekmedia commented Jun 15, 2023 •
edited
Loading

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Fixes #1436

@canihavesomecoffee
Copy link
Member

You forgot the windows sln's I think :)

@prateekmedia
Copy link
Member Author

The error is actually related to vcpkg, I will check to update that to latest commit hash.

@prateekmedia
Copy link
Member Author

@canihavesomecoffee This is ready to go! CI is also fixed now.

@cfsmp3 cfsmp3 self-requested a review July 5, 2023 10:52
@cfsmp3 cfsmp3 merged commit 35e73c1 into CCExtractor:master Jul 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfsmp3 cfsmp3 cfsmp3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PROPOSAL] bitstream.h is a very generic name
3 participants
@prateekmedia @canihavesomecoffee @cfsmp3